Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): implement on_page_load event using wry hook #8116

Merged
merged 4 commits into from
Oct 27, 2023
Merged

refactor(core): implement on_page_load event using wry hook #8116

merged 4 commits into from
Oct 27, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner October 26, 2023 14:35
amrbashir
amrbashir requested changes Oct 27, 2023
View reviewed changes
core/tauri/src/window/mod.rs Outdated Show resolved Hide resolved
core/tauri/src/window/mod.rs Outdated Show resolved Hide resolved
@lucasfernog lucasfernog requested a review from amrbashir October 27, 2023 12:03
@lucasfernog lucasfernog merged commit 74d2464 into dev Oct 27, 2023
31 checks passed
@lucasfernog lucasfernog deleted the refactor/on-page-load branch October 27, 2023 13:01
This was referenced Feb 14, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasfernog @amrbashir